Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Sun, 1 Jan 2017 15:54:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13031420.1483283004000.622073.1483286098492@Atlassian.JIRA>
In-Reply-To: <JIRA.13031420.1483283004000@Atlassian.JIRA>
References: <JIRA.13031420.1483283004000@Atlassian.JIRA> <JIRA.13031420.1483283004703@arcas>
Subject: [jira] [Commented] (ARTEMIS-904) Remove cyclic dependencies from
 artemis-cli
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 01 Jan 2017 15:55:00 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15791289#comment-15791289 ] 

ASF GitHub Bot commented on ARTEMIS-904:
----------------------------------------

Github user johnament commented on the issue:

    https://github.com/apache/activemq-artemis/pull/944
  
    Also it looks like you have two PRs with the same changes now.  We should merge one.


> Remove cyclic dependencies from artemis-cli
> -------------------------------------------
>
>                 Key: ARTEMIS-904
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-904
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Bennet Schulz
>
> The project needs some smaller refactorings. Some methods should be moved to another class which is responsible it (e.g. printBanner() in Artemis class should be moved to PrintData class.
> In addition to this simple case there are lots of other classes/packages which have cyclic dependencies.
> I already did such a refactoring for artemis-jdbc. (ARTEMIS-830 Remove cyclic dependencies from artemis-jdbc-store)
> We should track all our dependencies between classes and packages as the Spring guys do since quite a while


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)