activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-6561) Broker does not close connection for all connection attempt errors
Date Thu, 12 Jan 2017 15:22:52 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821246#comment-15821246
] 

ASF subversion and git services commented on AMQ-6561:
------------------------------------------------------

Commit df7aa6e892853fd442739a49417ecdf34a6cac63 in activemq's branch refs/heads/activemq-5.14.x
from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=df7aa6e ]

https://issues.apache.org/jira/browse/AMQ-6561

Stop connections on all connection attempt errors, not just security
exceptions, to prevent dangling open sockets.

(cherry picked from commit d9c74d7317677725a52466349f7ed91911664d3d)


> Broker does not close connection for all connection attempt errors
> ------------------------------------------------------------------
>
>                 Key: AMQ-6561
>                 URL: https://issues.apache.org/jira/browse/AMQ-6561
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.14.3
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>
> When a client connects to the broker the connection gets added inside the processAddConnection
method in TransportConnection.  Right now if there is an exception the socket is only shutdown
if the type of exception is SecurityException.  However the connection should really be closed
if any error occurs when trying to add the connection.  
> For example if an InvalidClientIDException occurs then the connection is no longer tracked
by the broker but the socket stays open until the client actually closes it on their end.
This should be fixed so that the error terminates the socket connection since the connection
attempt failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message