activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher L. Shannon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-6561) Broker does not close connection for all connection attempt errors
Date Mon, 16 Jan 2017 13:36:26 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823970#comment-15823970
] 

Christopher L. Shannon commented on AMQ-6561:
---------------------------------------------

Yes this bug can cause file descriptors to be leaked if the client does not close the connection.
 I'm not entirely sure when 5.14.4 will be released (I guess when we determine there is enough
bugs fixed) but if you update to 5.14.3 now then the update to 5.14.4 later would be pretty
easy.  

This bug has existed for a long time and is not new so I wouldn't necessarily hold off upgrading.
 The affects version should probably be updated to show that it actually goes back quite a
while.  I just listed the latest version but I believe this issue goes back several versions.

> Broker does not close connection for all connection attempt errors
> ------------------------------------------------------------------
>
>                 Key: AMQ-6561
>                 URL: https://issues.apache.org/jira/browse/AMQ-6561
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.14.3
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>             Fix For: 5.15.0, 5.14.4
>
>
> When a client connects to the broker the connection gets added inside the processAddConnection
method in TransportConnection.  Right now if there is an exception the socket is only shutdown
if the type of exception is SecurityException.  However the connection should really be closed
if any error occurs when trying to add the connection.  
> For example if an InvalidClientIDException occurs then the connection is no longer tracked
by the broker but the socket stays open until the client actually closes it on their end.
This should be fixed so that the error terminates the socket connection since the connection
attempt failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message