activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
Date Wed, 21 Dec 2016 15:55:58 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767389#comment-15767389
] 

ASF GitHub Bot commented on ARTEMIS-883:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/907#discussion_r93464460
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/BasicOpenWireTest.java
---
    @@ -64,6 +64,9 @@
        @Before
        public void setUp() throws Exception {
           super.setUp();
    +      System.setProperty("org.apache.activemq.transport.AbstractInactivityMonitor.keepAliveTime",
"5");
    --- End diff --
    
    shouldn't you remove this property on tearDown?
    
    What if another test is expecting this property differently? even if it's not the case
now, I think you should clear it on tearDown.



> Fix OpenWire ProducerFlowControlTest Regression
> -----------------------------------------------
>
>                 Key: ARTEMIS-883
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-883
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 1.5.1
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.5.next
>
>
> ProducerFlowControlTest fails due to regression



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message