activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Hammer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-6521) compatibility issue with jetty 9.3.11 in org.apache.activemq.transport.http.HttpTransportServer
Date Fri, 09 Dec 2016 13:33:59 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735325#comment-15735325
] 

Carsten Hammer commented on AMQ-6521:
-------------------------------------

Unfortunately the fix is wrong. This issue should be reopened. The code now looks like that:

private void addGzipHandler(ServletContextHandler contextHandler) throws Exception {
        Handler handler = null;
        try {
            handler = (Handler) forName("org.eclipse.jetty.server.handler.GzipHandler").newInstance();
        } catch (Throwable t) {
            handler = (Handler) forName("org.eclipse.jetty.servlets.gzip.GzipHandler").newInstance();
        }
        contextHandler.setHandler(handler);
    }

But the real class name seems to be (as is written in this issues description)

org.eclipse.jetty.server.handler.gzip.GzipHandler

and not one of these

org.eclipse.jetty.server.handler.GzipHandler
org.eclipse.jetty.servlets.gzip.GzipHandler

I guess it is difficult to provide a test for this, right?

> compatibility issue with jetty 9.3.11 in org.apache.activemq.transport.http.HttpTransportServer
> -----------------------------------------------------------------------------------------------
>
>                 Key: AMQ-6521
>                 URL: https://issues.apache.org/jira/browse/AMQ-6521
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.14.1
>            Reporter: Carsten Hammer
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>             Fix For: 5.15.0, 5.14.2
>
>
> There is a instantiation of a class that does not exists, see org.apache.activemq.transport.http.HttpTransportServer.java:
>  private void addGzipHandler(ServletContextHandler contextHandler) throws Exception {
>         Handler handler = new GzipHandler();
>         contextHandler.setHandler(handler);
>     }
> org.eclipse.jetty.servlets.gzip.GzipHandler does not exist. Instead there is a class
org.eclipse.jetty.server.handler.gzip.GzipHandler.java
> in https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.13.v20161014
> Because of this activemq is not compatible with jetty versions since 9.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message