Return-Path: <issues-return-12835-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3684B200BD3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 21 Nov 2016 13:47:02 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 33DE7160B19; Mon, 21 Nov 2016 12:47:02 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 88947160AEC
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 21 Nov 2016 13:47:01 +0100 (CET)
Received: (qmail 69685 invoked by uid 500); 21 Nov 2016 12:46:59 -0000
Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@activemq.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@activemq.apache.org>
List-Post: <mailto:issues@activemq.apache.org>
List-Id: <issues.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list issues@activemq.apache.org
Received: (qmail 69651 invoked by uid 99); 21 Nov 2016 12:46:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Nov 2016 12:46:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 975562C4C7A
	for <issues@activemq.apache.org>; Mon, 21 Nov 2016 12:46:59 +0000 (UTC)
Date: Mon, 21 Nov 2016 12:46:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13021780.1479485694000.327718.1479732419616@Atlassian.JIRA>
In-Reply-To: <JIRA.13021780.1479485694000@Atlassian.JIRA>
References: <JIRA.13021780.1479485694000@Atlassian.JIRA> <JIRA.13021780.1479485694815@arcas>
Subject: [jira] [Commented] (ARTEMIS-859) Enable BACKLOG_PROP_NAME
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 21 Nov 2016 12:47:02 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683495#comment-15683495 ] 

ASF GitHub Bot commented on ARTEMIS-859:
----------------------------------------

GitHub user SAppleton opened a pull request:

    https://github.com/apache/activemq-artemis/pull/893

    ARTEMIS-859 : Enable BACKLOG_PROP_NAME

    PR for https://issues.apache.org/jira/browse/ARTEMIS-859

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SAppleton/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #893
    
----
commit 5d4790333ade64cf2663dbfa1e04ad0cabf264a1
Author: Shaun Appleton <sappleto@redhat.com>
Date:   2016-11-21T12:38:40Z

    Enable BACKLOG_PROP_NAME

----


> Enable BACKLOG_PROP_NAME
> ------------------------
>
>                 Key: ARTEMIS-859
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-859
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Shaun Appleton
>
> org/apache/arctivemq/artemis/core/remoting/impl/netty/TransportConstants.java uses a hashmap named allowableAcceptorKeys which does not allow the BACKLOG_PROP_NAME to be set, even though it is there.
> The change is to add the line
>  allowableAcceptorKeys.add(TransportConstants.BACKLOG_PROP_NAME);
> Changing the netty acceptors to include backlog is also needed as follows
> <acceptors>
> <netty-acceptor name="netty" socket-binding="messaging">
> <param key="use-nio" value="true"/>
> <param key="backlog" value="1028"/>
> </netty-acceptor>
> <netty-acceptor name="netty-throughput" socket-binding="messaging-throughput">
> <param key="batch-delay" value="50"/>
> <param key="direct-deliver" value="false"/>
> <param key="use-nio" value="true"/>
> <param key="backlog" value="1028"/>
> </netty-acceptor>
> </acceptors>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)