activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-859) Enable BACKLOG_PROP_NAME
Date Mon, 21 Nov 2016 12:46:59 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683495#comment-15683495
] 

ASF GitHub Bot commented on ARTEMIS-859:
----------------------------------------

GitHub user SAppleton opened a pull request:

    https://github.com/apache/activemq-artemis/pull/893

    ARTEMIS-859 : Enable BACKLOG_PROP_NAME

    PR for https://issues.apache.org/jira/browse/ARTEMIS-859

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SAppleton/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #893
    
----
commit 5d4790333ade64cf2663dbfa1e04ad0cabf264a1
Author: Shaun Appleton <sappleto@redhat.com>
Date:   2016-11-21T12:38:40Z

    Enable BACKLOG_PROP_NAME

----


> Enable BACKLOG_PROP_NAME
> ------------------------
>
>                 Key: ARTEMIS-859
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-859
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Shaun Appleton
>
> org/apache/arctivemq/artemis/core/remoting/impl/netty/TransportConstants.java uses a
hashmap named allowableAcceptorKeys which does not allow the BACKLOG_PROP_NAME to be set,
even though it is there.
> The change is to add the line
>  allowableAcceptorKeys.add(TransportConstants.BACKLOG_PROP_NAME);
> Changing the netty acceptors to include backlog is also needed as follows
> <acceptors>
> <netty-acceptor name="netty" socket-binding="messaging">
> <param key="use-nio" value="true"/>
> <param key="backlog" value="1028"/>
> </netty-acceptor>
> <netty-acceptor name="netty-throughput" socket-binding="messaging-throughput">
> <param key="batch-delay" value="50"/>
> <param key="direct-deliver" value="false"/>
> <param key="use-nio" value="true"/>
> <param key="backlog" value="1028"/>
> </netty-acceptor>
> </acceptors>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message