activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-803) Do not offset port for http-upgrade acceptor for colocated backups
Date Tue, 18 Oct 2016 12:15:58 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585312#comment-15585312
] 

ASF GitHub Bot commented on ARTEMIS-803:
----------------------------------------

GitHub user jmesnil opened a pull request:

    https://github.com/apache/activemq-artemis/pull/846

    [ARTEMIS-803] Fix colocated backups with http-upgrade acceptor

    *  Do not offset ports for Netty connector/acceptor with http-upgrade
    enabled.
    * Pass the name of the ActiveMQ server to the HTTP request to initiate
    the Upgrade so that the HTTP endpoint on the app server can find the
    correct ActiveMQ broker that must handle the upgrade.
    
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-803

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-803_colocated_http-acceptor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #846
    
----
commit 20d06d2db22a32949625c0db9544a8d27e473ba9
Author: Jeff Mesnil <jmesnil@gmail.com>
Date:   2016-10-17T09:42:57Z

    [ARTEMIS-803] Fix colocated backups with http-upgrade acceptor
    
    *  Do not offset ports for Netty connector/acceptor with http-upgrade
    enabled.
    * Pass the name of the ActiveMQ server to the HTTP request to initiate
    the Upgrade so that the HTTP endpoint on the app server can find the
    correct ActiveMQ broker that must handle the upgrade.
    
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-803

----


> Do not offset port for http-upgrade acceptor for colocated backups
> ------------------------------------------------------------------
>
>                 Key: ARTEMIS-803
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-803
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.4.0
>            Reporter: Jeff Mesnil
>
> In our application server, we use an embedded Artemis server with netty acceptors configured
to enable HTTP Upgrade.
> This means that the app server is using the HTTP port to negotiate a HTTP upgrade handshake
with Artemis client. If the handshake is succesful, we transfer the connection from our HTTP
handler to Artemis netty channel.
> This causes issue with colocated backups as Artemis offsets all the ports for the Netty
acceptor. If HTTP Upgrade is enabled, the port should not be offset (as it is "owned" by the
app server).
> Additionally, with colocated backups we have a single entry point (the app server's HTTP
port) that can be used by multiple Artemis server (the main one and any of its colocated backups).
When Artemis sends the HTTP request to initiate the upgrade, it should pass the name of the
Artemis server that should handle the upgrade so that the app server can delegate the actual
handshake to the correct Artemis server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message