Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Tue, 20 Sep 2016 14:53:20 +0000 (UTC)
From: "clebert suconic (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13006163.1474365321000.616380.1474383200610@Atlassian.JIRA>
In-Reply-To: <JIRA.13006163.1474365321000@Atlassian.JIRA>
References: <JIRA.13006163.1474365321000@Atlassian.JIRA> <JIRA.13006163.1474365321930@arcas>
Subject: [jira] [Comment Edited] (ARTEMIS-740) Auto-reload diverts from
 broker.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 20 Sep 2016 14:53:22 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-740?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D155=
06796#comment-15506796 ]=20

clebert suconic edited comment on ARTEMIS-740 at 9/20/16 2:52 PM:
------------------------------------------------------------------

The implementation should be simple.


on ActiveMQServerImpl, ConfigurationFileReloader, on the reload method, som=
eone should:


      for (DivertConfiguration config : configuration.getDivertConfiguratio=
ns()) {
         deployDivert(config);
      }


Although there is an extra step to be done. Right now the code would duplic=
ate diverts. So we would need to verify if the Divert already exists before=
 duplicating it.

I don't expect to delete diverts, same way as this is not removing queues.


was (Author: clebertsuconic):
The implementation should be simple.


on ActiveMQServerImpl, ConfigurationFileReloader, on the reload method, som=
eone should:

```
      for (DivertConfiguration config : configuration.getDivertConfiguratio=
ns()) {
         deployDivert(config);
      }
```


Although there is an extra step to be done. Right now the code would duplic=
ate diverts. So we would need to verify if the Divert already exists before=
 duplicating it.

I don't expect to delete diverts, same way as this is not removing queues.

> Auto-reload diverts from broker.xml
> -----------------------------------
>
>                 Key: ARTEMIS-740
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-740
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 1.4.0
>            Reporter: Ville Skytt=C3=A4
>             Fix For: 1.5.0
>
>
> Automatic reloading of diverts from broker.xml would be equally useful as=
 for addresses, security, and jms destinations, see ARTEMIS-601


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)