activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-743) Default the queue address to the queue name
Date Wed, 21 Sep 2016 15:23:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510276#comment-15510276
] 

ASF GitHub Bot commented on ARTEMIS-743:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/787#discussion_r79860068
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
---
    @@ -0,0 +1,242 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.server;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.core.filter.Filter;
    +import org.apache.activemq.artemis.core.filter.FilterUtils;
    +import org.apache.activemq.artemis.core.paging.PagingManager;
    +import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
    +
    +public final class QueueConfig {
    +
    +   private final long id;
    --- End diff --
    
    The id is assigned when the queue is persisted. Why this is part of the config options?


> Default the queue address to the queue name
> -------------------------------------------
>
>                 Key: ARTEMIS-743
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-743
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Francesco Nigro
>              Labels: features
>
> In many instances, users will want the queue name and address to be the same. The latter
could default to the queue name, and then it would be safe to omit the address in the queue
config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message