activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "clebert suconic (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ARTEMIS-740) Auto-reload diverts from broker.xml
Date Tue, 20 Sep 2016 14:53:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506796#comment-15506796
] 

clebert suconic edited comment on ARTEMIS-740 at 9/20/16 2:52 PM:
------------------------------------------------------------------

The implementation should be simple.


on ActiveMQServerImpl, ConfigurationFileReloader, on the reload method, someone should:


      for (DivertConfiguration config : configuration.getDivertConfigurations()) {
         deployDivert(config);
      }



Although there is an extra step to be done. Right now the code would duplicate diverts. So
we would need to verify if the Divert already exists before duplicating it.

I don't expect to delete diverts, same way as this is not removing queues.


was (Author: clebertsuconic):
The implementation should be simple.


on ActiveMQServerImpl, ConfigurationFileReloader, on the reload method, someone should:

```
      for (DivertConfiguration config : configuration.getDivertConfigurations()) {
         deployDivert(config);
      }
```


Although there is an extra step to be done. Right now the code would duplicate diverts. So
we would need to verify if the Divert already exists before duplicating it.

I don't expect to delete diverts, same way as this is not removing queues.

> Auto-reload diverts from broker.xml
> -----------------------------------
>
>                 Key: ARTEMIS-740
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-740
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 1.4.0
>            Reporter: Ville Skyttä
>             Fix For: 1.5.0
>
>
> Automatic reloading of diverts from broker.xml would be equally useful as for addresses,
security, and jms destinations, see ARTEMIS-601



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message