activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-706) InactivityIOException - Perhaps No Keep Alives From Broker?
Date Fri, 02 Sep 2016 02:23:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457275#comment-15457275
] 

ASF GitHub Bot commented on ARTEMIS-706:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/740#discussion_r77284769
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
    @@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws Exception {
           }
        }
     
    +   public void setConnectionEntry(ConnectionEntry connectionEntry) {
    +      this.connectionEntry = connectionEntry;
    +   }
    +
    +   public void setUpTtl(final long inactivityDuration, final long inactivityDurationInitialDelay,
final boolean useKeepAlive) {
    +      this.useKeepAlive = useKeepAlive;
    +      this.maxInactivityDuration = inactivityDuration;
    +
    +      protocolManager.getScheduledPool().schedule(new Runnable() {
    --- End diff --
    
    @gaohoward Really? I thought they were different like AMQP.
    
    Why do you need the scheduled executor then? just to set the variable?
    
    
          protocolManager.getScheduledPool().schedule(new Runnable() {
             @Override
             public void run() {
                if (inactivityDuration >= 0) {
                   connectionEntry.ttl = inactivityDuration;
                }
             }
          }, inactivityDurationInitialDelay, TimeUnit.MILLISECONDS);



> InactivityIOException - Perhaps No Keep Alives From Broker?
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-706
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-706
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 1.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.5.0
>
>
> Broker doesn't handle the openwire Inactivity timeouts properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message