Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Wed, 31 Aug 2016 14:16:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13001023.1472486298000.458369.1472652980698@Atlassian.JIRA>
In-Reply-To: <JIRA.13001023.1472486298000@Atlassian.JIRA>
References: <JIRA.13001023.1472486298000@Atlassian.JIRA> <JIRA.13001023.1472486298384@arcas>
Subject: [jira] [Commented] (ARTEMIS-706) InactivityIOException - Perhaps No
 Keep Alives From Broker?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 Aug 2016 14:16:22 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452351#comment-15452351 ] 

ASF GitHub Bot commented on ARTEMIS-706:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/740#discussion_r76995434
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java ---
    @@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws Exception {
           }
        }
     
    +   public void setConnectionEntry(ConnectionEntry connectionEntry) {
    +      this.connectionEntry = connectionEntry;
    +   }
    +
    +   public void setUpTtl(final long inactivityDuration, final long inactivityDurationInitialDelay, final boolean useKeepAlive) {
    +      this.useKeepAlive = useKeepAlive;
    +      this.maxInactivityDuration = inactivityDuration;
    +
    +      protocolManager.getScheduledPool().schedule(new Runnable() {
    --- End diff --
    
    Actually.. scratch what I said before..  I thought the incoming pings were being duplicated.
    
    
    The only issues I see now are:
    
    i - nothing is cancelling the scheduler.
    
    ii - you should call checkInactivity within the Runnable on the scheduler.


> InactivityIOException - Perhaps No Keep Alives From Broker?
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-706
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-706
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 1.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.5.0
>
>
> Broker doesn't handle the openwire Inactivity timeouts properly.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)