Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 515E0200B53 for ; Tue, 12 Jul 2016 18:39:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4FFF3160A56; Tue, 12 Jul 2016 16:39:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D93E160A75 for ; Tue, 12 Jul 2016 18:39:21 +0200 (CEST) Received: (qmail 36372 invoked by uid 500); 12 Jul 2016 16:39:20 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 36286 invoked by uid 99); 12 Jul 2016 16:39:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 16:39:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 926602C02AE for ; Tue, 12 Jul 2016 16:39:20 +0000 (UTC) Date: Tue, 12 Jul 2016 16:39:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-6301) Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 12 Jul 2016 16:39:22 -0000 [ https://issues.apache.org/jira/browse/AMQ-6301?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D153731= 92#comment-15373192 ]=20 ASF subversion and git services commented on AMQ-6301: ------------------------------------------------------ Commit 6c2ce67ffbde081f1db75002c8b41c3c7b7bb166 in activemq's branch refs/h= eads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=3Dactivemq.git;h=3D6c2ce67 ] https://issues.apache.org/jira/browse/AMQ-6301 Updating ActiveMQServiceFactory to avoid using Spring DM directly and instead use the Camel factory bean if it exists Reverting back to Camel 2.16.3 until Spring DM is removed and Spring 4 can be used > Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf > -------------------------------------------------------------------- > > Key: AMQ-6301 > URL: https://issues.apache.org/jira/browse/AMQ-6301 > Project: ActiveMQ > Issue Type: Improvement > Components: OSGi/Karaf > Affects Versions: 5.13.0 > Reporter: Seth Leger > Labels: patch > > Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf > In commit 3a6d67e8f95320bea91b7c7106173c9b34773bc5, a test was fixed in i= ssue AMQ-4727 by reusing the spring-dm OsgiBundleXmlApplicationContext clas= s inside the ActiveMQServiceFactory managed service factory. > To satisfy the import packages for activemq-osgi, the 'spring-dm' Karaf f= eature was added to the main 'activemq-client' feature. > This is problematic because loading the 'spring-dm' Karaf feature enables= the Spring DM deployer. This deployer is unnecessary in environments that = rely on Blueprint or CDI wiring and it may unexpectedly activate Spring DM = bundles in those environments. Because spring-dm was compiled against older= versions of Spring 3.0 and 3.1, it can also cause older versions of Spring= features to be loaded into the container. > To avoid using the =E2=80=98spring-dm=E2=80=99 Karaf feature to provide t= he classes, I propose embedding the spring-dm bundles inside activemq-osgi.= Since they are only used as library code to provide the BundleContext when= parsing the BrokerService context, they can be embedded safely without any= dependency issues. > This is the root cause of the following issue: > http://karaf.922171.n3.nabble.com/Karaf-4-0-3-unable-to-start-bundle-acti= vemq-osgi-5-13-0-td4044640.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)