activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-642) Disable slow client reconnecting with KILL slow client policy
Date Thu, 28 Jul 2016 21:20:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398236#comment-15398236
] 

ASF GitHub Bot commented on ARTEMIS-642:
----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/672
  
    This is much better... now the only thing wrong is the versioning.
    
    There's no need to add any fields. When the client connects to the server it will set
the versionID when the session is created.
    
    
    You just need to increase the versionID. Check if the client.version is >= the supported
version (You will need to create some constant for that on the Packet.. liker version created
or so)... and only send the kill if the client understands this command.
    
    
    This is important not only for legacy support, but even to support 1.0, 1.1, 1.2 and 1.3
when we release 1.4+.


> Disable slow client reconnecting with KILL slow client policy
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-642
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-642
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>    Affects Versions: 1.3.0
>            Reporter: Chen Maoqian
>            Priority: Minor
>
> It is possible to detect and handle(KILL, NOTIFY) slow consumers. In case policy KILL
is used and connection factory used to create connection of slow consumer has attribute reconnect-attempts
set to "-1", slow consumer reconnects to server. This consumer is then reconnects, is detected
as slow and disconnected. 
> Attribute reconnect-attempts="-1" should be ignored, and slow client should not be trying
to reconnect once it is disconnected by KILL slow consumer policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message