activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-642) Disable slow client reconnecting with KILL slow client policy
Date Thu, 28 Jul 2016 19:30:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398087#comment-15398087
] 

ASF GitHub Bot commented on ARTEMIS-642:
----------------------------------------

Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72686692
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -759,6 +769,12 @@ protected void handleReceiveProducerFailCredits(SessionProducerCreditsFailMessag
           handleReceiveProducerFailCredits(message.getAddress(), message.getCredits());
        }
     
    +   protected void handleReceiveSlowConsumerKillMessage(DisconnectConsumerWithKillMessage
message) {
    +      if (message.getNodeID() != null) {
    +         setKilled(true);
    --- End diff --
    
    since its always called with true, would it make sense to have a `kill()` method instead?


> Disable slow client reconnecting with KILL slow client policy
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-642
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-642
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>    Affects Versions: 1.3.0
>            Reporter: Chen Maoqian
>            Priority: Minor
>
> It is possible to detect and handle(KILL, NOTIFY) slow consumers. In case policy KILL
is used and connection factory used to create connection of slow consumer has attribute reconnect-attempts
set to "-1", slow consumer reconnects to server. This consumer is then reconnects, is detected
as slow and disconnected. 
> Attribute reconnect-attempts="-1" should be ignored, and slow client should not be trying
to reconnect once it is disconnected by KILL slow consumer policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message