activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ville Skyttä (JIRA) <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-611) Refactor STOMP connection TTL & heart-beat functionality
Date Thu, 28 Jul 2016 16:37:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397785#comment-15397785
] 

Ville Skyttä commented on ARTEMIS-611:
--------------------------------------

[~jbertram], Looking at the code added to StompConnection in 7d8f9dcec690870197f7e0a6eb5f4335ac49aca4,
is the "me != null" check necessary? If "me" is null, a NPE will be thrown a few lines after
that anyway, in ActiveMQServerLogger.LOGGER.connectionFailureDetected(me.getMessage(), me.getType()),
and I suppose callFailureListeners() is not supposed to be called with a null excecption either.

Briefly skimming the fail() invocations I couldn't find a case where it would be called with
a null ActiveMQException, so maybe the check can be just removed?

> Refactor STOMP connection TTL & heart-beat functionality
> --------------------------------------------------------
>
>                 Key: ARTEMIS-611
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-611
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>             Fix For: 1.4.0
>
>
> With the default configuration, a STOMP 1.0 consumer that subscribes to a destination
and waits for messages to come gets killed after some time (in case there are no messages
coming).
> The broker logs:
> {code}
> 2016-07-04 09:34:31,260 [org.apache.activemq.artemis.core.server] WARN AMQ222067: Connection
failure has been detected: AMQ119014: Did not receive data from /192.168.47.193:54716. It
is likely the client has exited or crashed without closing its connection, or the network
between the server and client has failed. You also might have configured connection-ttl and
client-failure-check-period incorrectly. Please check user manual for more information. The
connection will now be closed. [code=CONNECTION_TIMEDOUT]
> 2016-07-04 09:34:31,261 [org.apache.activemq.artemis.core.server] WARN AMQ222061: Client
connection failed, clearing up resources for session 9ae78c80-41b9-11e6-8647-02163e018512
> 2016-07-04 09:34:31,263 [org.apache.activemq.artemis.core.server] WARN AMQ222107: Cleared
up resources for session 9ae78c80-41b9-11e6-8647-02163e018512
> {code}
> STOMP 1.0 clients do not support heart-beats and the broker should not kill connections
after some period of inactivity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message