activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-595) When creating JMS bridge management API should pass bridge name to JMS broker
Date Thu, 28 Jul 2016 14:31:20 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397605#comment-15397605
] 

ASF GitHub Bot commented on ARTEMIS-595:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/677#discussion_r72632899
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/CoreMessagingProxy.java
---
    @@ -30,21 +33,20 @@
     
        private final String resourceName;
     
    -   private final ClientSession session;
    +   private final ServerLocator locator;
     
    -   private final ClientRequestor requestor;
    +   private ClientSessionFactory sessionFactory;
    --- End diff --
    
    If you are always opening / closing on each call, why not to make it part of the method.
    
    What was the reason to not reuse the session?


> When creating JMS bridge management API should pass bridge name to JMS broker
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-595
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-595
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.3.0
>            Reporter: Chen Maoqian
>
> In situations where there are multiple JMS bridges being created it woudl help if bridge
name is logged in the server name. This helps with recognising which JMS bridge  is having
problems.
> For this to work the JBoss messaging API layer has to pass bridge name to the JMS broker.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message