activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher L. Shannon (JIRA)" <>
Subject [jira] [Commented] (AMQ-6301) Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf
Date Wed, 13 Jul 2016 13:55:20 GMT


Christopher L. Shannon commented on AMQ-6301:

I looked at the test a bit and it is still broken.  The good news is that when running it
the camel changes are picked up when deployed.  The problem is that the bundle is refreshed
after camel is dynamically added and this is causing the test to have a ClassNotFoundException
that says the bundle wiring is no longer valid because PaxExam is now running inside of a
bundle that has been refreshed, etc.  This is most likely just a test issue and not going
to be a problem with a real instance.

> Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf
> --------------------------------------------------------------------
>                 Key: AMQ-6301
>                 URL:
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: OSGi/Karaf
>    Affects Versions: 5.13.0
>            Reporter: Seth Leger
>            Assignee: Christopher L. Shannon
>              Labels: patch
>             Fix For: 5.14.0, 5.13.4
> Embed spring-dm in activemq-osgi to avoid loading spring-dm in Karaf
> In commit 3a6d67e8f95320bea91b7c7106173c9b34773bc5, a test was fixed in issue AMQ-4727
by reusing the spring-dm OsgiBundleXmlApplicationContext class inside the ActiveMQServiceFactory
managed service factory.
> To satisfy the import packages for activemq-osgi, the 'spring-dm' Karaf feature was added
to the main 'activemq-client' feature.
> This is problematic because loading the 'spring-dm' Karaf feature enables the Spring
DM deployer. This deployer is unnecessary in environments that rely on Blueprint or CDI wiring
and it may unexpectedly activate Spring DM bundles in those environments. Because spring-dm
was compiled against older versions of Spring 3.0 and 3.1, it can also cause older versions
of Spring features to be loaded into the container.
> To avoid using the ‘spring-dm’ Karaf feature to provide the classes, I propose embedding
the spring-dm bundles inside activemq-osgi. Since they are only used as library code to provide
the BundleContext when parsing the BrokerService context, they can be embedded safely without
any dependency issues.
> This is the root cause of the following issue:

This message was sent by Atlassian JIRA

View raw message