Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05E93200AE4 for ; Tue, 10 May 2016 16:06:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0493D16098A; Tue, 10 May 2016 14:06:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71057160A12 for ; Tue, 10 May 2016 16:06:14 +0200 (CEST) Received: (qmail 248 invoked by uid 500); 10 May 2016 14:06:13 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 99992 invoked by uid 99); 10 May 2016 14:06:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 14:06:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 404132C1F71 for ; Tue, 10 May 2016 14:06:13 +0000 (UTC) Date: Tue, 10 May 2016 14:06:13 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-5621) Unit tests cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 May 2016 14:06:15 -0000 [ https://issues.apache.org/jira/browse/AMQ-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278140#comment-15278140 ] ASF subversion and git services commented on AMQ-5621: ------------------------------------------------------ Commit 3da9b0720efa4f8c55b8d04d3b584637a25ac1da in activemq's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=3da9b07 ] https://issues.apache.org/jira/browse/AMQ-5621 Remove hard coded port as the bridge brokers method doesn't need the port to be fixed. Turn off JMX since the test doesn't use it. > Unit tests cleanup > ------------------ > > Key: AMQ-5621 > URL: https://issues.apache.org/jira/browse/AMQ-5621 > Project: ActiveMQ > Issue Type: Improvement > Reporter: Timothy Bish > Assignee: Timothy Bish > Priority: Minor > > Many of the existing test cases take longer than they should and fail randomly due to BrokerService instances that are still running that have open JMX connectors etc. We should take some time to review tests and clean up were we can. > Removing hard sleeps and using admin view to check statistics can dramatically shorten a test. Also the tests can be configured not to create JMX connectors as none of them need that in the normal case. > Other tasks that could be done is to update tests to JUnit 4 based tests with test timeouts to help prevent CI hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)