activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrik Dudits (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AMQ-6209) Unmatched messages on consumer queues when using SubQueueCacheSelectorPlugin in network of browsers
Date Mon, 16 May 2016 09:21:15 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284283#comment-15284283
] 

Patrik Dudits edited comment on AMQ-6209 at 5/16/16 9:20 AM:
-------------------------------------------------------------

I will gladly comply, however I need to know what code did you run and in what environment,
as [{{TwoBrokerVirtualTopicSelectorFailoverTest.java:137}}|https://github.com/apache/activemq/pull/174/files#diff-8a4e7ffbae789929bba4db6912813a58R137]
is start of multiline comment in the PR and the test passes for me on Windows, JDK 1.8.0_45
and Maven 3.3.9.

Since that method is only used once, it might correspond to line 124. And it could fail only
if broker A failed to restart - a situation that is not explicitly checked in the test ({{broker.waitUntilStarted}}
returning {{false}}). Is there more information in your test output why that happened?


was (Author: pdudits):
I will gladly comply, however I need to know what code did you run and in what environment,
as [{{TwoBrokerVirtualTopicSelectorFailoverTest.java:137}}|https://github.com/apache/activemq/pull/174/files#diff-8a4e7ffbae789929bba4db6912813a58R137]
is start of multiline comment in the PR and the test passes for me on Windows, JDK 1.8.0_45
and Maven 3.3.9.

> Unmatched messages on consumer queues when using SubQueueCacheSelectorPlugin in network
of browsers
> ---------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-6209
>                 URL: https://issues.apache.org/jira/browse/AMQ-6209
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.13.2
>            Reporter: Patrik Dudits
>
> When using SubQueueSelectorCachePlugin to preserve consumers' selectors in network of
brokers, the queues start matching all messages after consumers failover between brokers.
> The underlying reason is, that {{SubQueueSelectorCacheBroker}} would cache selector {{TRUE}}
for connected demand subscription, and therefore will permanently match all messages even
if actual consumer reconnects.
> Additionally, browsing the queue will also cause {{TRUE}} selector to be persisted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message