Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Fri, 29 Apr 2016 15:49:13 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.12939189.1455517494000.70918.1461944953000@Atlassian.JIRA>
In-Reply-To: <JIRA.12939189.1455517494000@Atlassian.JIRA>
References: <JIRA.12939189.1455517494000@Atlassian.JIRA>
 <JIRA.12939189.1455517494268@arcas>
Subject: [jira] [Commented] (ARTEMIS-397) MQTT protocol - connection TTL =
 keepAliveTimeSeconds * 750
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/ARTEMIS-397?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D152=
64223#comment-15264223 ]=20

ASF GitHub Bot commented on ARTEMIS-397:
----------------------------------------

GitHub user incarosegit opened a pull request:

    https://github.com/apache/activemq-artemis/pull/497

    Change keep alive ratio to 1.5 from 0.75

    Fixes: ARTEMIS-397
   =20
    From mqtt specs:
   =20
    =E2=80=9CIf the Keep Alive value is non-zero and the Server does not re=
ceive a
    Control Packet from the Client within one and a half times the Keep
    Alive time period, it MUST disconnect the Network Connection to the
    Client as if the network had failed [MQTT-3.1.2-24]. =E2=80=9C

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/incarosegit/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #497
   =20
----
commit 6bdad3db2a8e19069f7d1d5b44c97ceb0fc05b92
Author: Diego Bes <dbesprosvan@tangome-macbook-pro.local>
Date:   2016-04-29T15:43:25Z

    Change keep alive ratio to 1.5 from 0.75
   =20
    Fixes: ARTEMIS-397
   =20
    From mqtt specs:
   =20
    =E2=80=9CIf the Keep Alive value is non-zero and the Server does not re=
ceive a
    Control Packet from the Client within one and a half times the Keep
    Alive time period, it MUST disconnect the Network Connection to the
    Client as if the network had failed [MQTT-3.1.2-24]. =E2=80=9C

----


> MQTT protocol - connection TTL =3D keepAliveTimeSeconds * 750
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-397
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-397
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0
>            Reporter: hiawui
>
> For MQTT protocol, the connection TTL is equal to keepAliveTimeSeconds * =
750, causes connections always disconnected by timeout. Is it a bug? or why=
?
> {code:title=3DMQTTProtocolHandler.java:159|borderStyle=3Dsolid}
>    void handleConnect(MqttConnectMessage connect, ChannelHandlerContext c=
tx) throws Exception {
>       this.ctx =3D ctx;
>       connectionEntry.ttl =3D connect.variableHeader().keepAliveTimeSecon=
ds() * 750; // this line!!!, why not multiply by larger than 1000?
>       String clientId =3D connect.payload().clientIdentifier();
>       session.getConnectionManager().connect(clientId, connect.payload().=
userName(), connect.payload().password(), connect.variableHeader().isWillFl=
ag(), connect.payload().willMessage(), connect.payload().willTopic(), conne=
ct.variableHeader().isWillRetain(), connect.variableHeader().willQos(), con=
nect.variableHeader().isCleanSession());
>    }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)