activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ARTEMIS-488) Fix OpenWire Test (Temp Queue removal and others)
Date Tue, 19 Apr 2016 19:34:25 GMT


ASF GitHub Bot commented on ARTEMIS-488:

Github user clebertsuconic commented on the pull request:
    Ok, I like the SendResult idea after all. With just a few modifications to make it really
cool and a consistent API.
    - Rename SendResult as RoutingStatus (or find a better name, being part of Routing)
    - Move it under org.apache.activemq.artemis.core.postoffice
    - The enum constants should be. (No need to set any prefix on them).
    - Notice that there's no need for SEND_NO_DLA API wise.. just make it NO_BINDINGS.
    - Also, make all the PostOffice::route operations to return RoutingStatus. to make the
API clean.

> Fix OpenWire Test (Temp Queue removal and others)
> -------------------------------------------------
>                 Key: ARTEMIS-488
>                 URL:
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 1.2.0
>            Reporter: Howard Gao
>             Fix For: 1.3.0
> Temp Queue not deleted when connection is closed.
> Enable Stomp in openwire test because some test uses it.
> Remove unused code in opwnwire
> Wrong XA error code returned when xid is missing
> (ActiveMQXAConnectionFactory.testRollbackXaErrorCode)
> regression in ActiveMQSslConnectionFactoryTest (SSL related)

This message was sent by Atlassian JIRA

View raw message