Return-Path: X-Original-To: apmail-activemq-issues-archive@minotaur.apache.org Delivered-To: apmail-activemq-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA0D71838F for ; Tue, 3 Nov 2015 15:05:30 +0000 (UTC) Received: (qmail 16482 invoked by uid 500); 3 Nov 2015 15:05:27 -0000 Delivered-To: apmail-activemq-issues-archive@activemq.apache.org Received: (qmail 16445 invoked by uid 500); 3 Nov 2015 15:05:27 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 16429 invoked by uid 99); 3 Nov 2015 15:05:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2015 15:05:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AA9012C14E1 for ; Tue, 3 Nov 2015 15:05:27 +0000 (UTC) Date: Tue, 3 Nov 2015 15:05:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-292) isSameHost doesn't work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987421#comment-14987421 ] ASF GitHub Bot commented on ARTEMIS-292: ---------------------------------------- Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/229#issuecomment-153382366 there's a typo on your commit, you want to fix it? > isSameHost doesn't work > ----------------------- > > Key: ARTEMIS-292 > URL: https://issues.apache.org/jira/browse/ARTEMIS-292 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Affects Versions: 1.1.0 > Reporter: Andy Taylor > Assignee: Andy Taylor > > TransportConfiguration.isSameHost(...) does a comparison on all the params which is incorrect for some scenarios. It needs to check the host/port or serverID but only be changed for the calls that needs it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)