activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop
Date Thu, 05 Nov 2015 02:33:27 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990990#comment-14990990
] 

ASF GitHub Bot commented on ARTEMIS-297:
----------------------------------------

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/237

    ARTEMIS-297 Including acceptor name on logs

    This is just so users will know the name of the acceptor that had the issue on logs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit 0ab72f584b80f56b6c4ae9c612aff61253851dfa
Author: Clebert Suconic <clebertsuconic@apache.org>
Date:   2015-11-05T02:30:53Z

    ARTEMIS-297 Including acceptor name on logs

----


> Handle exceptions during server stop
> ------------------------------------
>
>                 Key: ARTEMIS-297
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-297
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an exception during
shutdown, the exception is thrown and the method exits.  Instead the stop method on the server
should be able to handle such exceptions and continue shutting down all components and eventually
stop the ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message