activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5996) Durable subscription no updated when reactivated sub changes noLocal value
Date Thu, 01 Oct 2015 23:32:26 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940593#comment-14940593
] 

ASF subversion and git services commented on AMQ-5996:
------------------------------------------------------

Commit 82a2c0553a97cc087ddfceeddef0ea677d39ee9d in activemq's branch refs/heads/activemq-5.12.x
from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=82a2c05 ]

https://issues.apache.org/jira/browse/AMQ-5996

When possible check for noLocl changes on durable subscription
reactivation and recreate the durable sub if it changes.  For both
selector change and noLocal change also update the AbstractSubscription
selectorExpression so it matches with what was requested.
(cherry picked from commit 81b4b9ae3d17c83c42c17290348e2aed6f17d28b)


> Durable subscription no updated when reactivated sub changes noLocal value
> --------------------------------------------------------------------------
>
>                 Key: AMQ-5996
>                 URL: https://issues.apache.org/jira/browse/AMQ-5996
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.10.2, 5.11.2, 5.12.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>             Fix For: 5.12.1, 5.13.0
>
>
> When a durable subscription that was offline is reactivated and the selector or noLocal
value is changed the subscription is supposed to be removed and re-added as if it was a new
subscription.  We currently handle the selector part to a certain extent but the DurableSubscription
instance that backs the offline durable sub contains a selectorExpression that is not updated
so subscription will not apply the new selector value unless the broker was restarted before
the reactivation.  
> We don't as of yet handle the change of noLocal on the subscription due to the fact that
prior to v5.12.0 the value was not stored in the persistence layer.  Now that we store the
noLocal value we can check that along with the selector and update the subscription, which
also needs to update the selectorExpression as the noLocal value is filtered via its own expression
on the selector chain.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message