activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5889) Support a single port for all wire protocols
Date Tue, 11 Aug 2015 21:24:45 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692283#comment-14692283
] 

Timothy Bish commented on AMQ-5889:
-----------------------------------

The following files are missing license headers:

activemq-broker/src/main/java/org/apache/activemq/broker/transport/protocol/ProtocolVerifier.java
activemq-broker/src/main/java/org/apache/activemq/broker/transport/auto/nio/AutoNIOSSLTransportServer.java

You can check this prior to commit using the following:
{noformat}
mvn -e apache-rat:check
grep -e ' !?????' target/rat.txt
{noformat}

I would also suggest that these belong in the transport package minus the 'broker' bit to
be more in line with the other transport bits.  

I also noticed that some places there are if statements that lack brackets which is not in
keeping with the [Java style guide|http://google.github.io/styleguide/javaguide.html] code
formatting.  While we don't have an explicit style guide I would prefer we tried to stick
to the practice of always using brackets as not doing so invites someone to make an error
later on. 



> Support a single port for all wire protocols
> --------------------------------------------
>
>                 Key: AMQ-5889
>                 URL: https://issues.apache.org/jira/browse/AMQ-5889
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.11.1
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>             Fix For: 5.13.0
>
>
> Both Apollo and Artemis support the ability to use a single port for all protocols and
to have automatic detection for the protocol being used.  It would be nice to be able to support
at least a subset of this feature in the 5.x broker as well.
> Ideally we should at least be able to detect OpenWire, MQTT, STOMP, and AMQP over a TCP,
SSL, and NIO transport.  Websockets and HTTP would be a bonus but could be more difficult
to implement depending on how this could work with Jetty so that would take some investigation.
> This is especially useful in environments where having to open up several new ports can
be difficult because of firewall and security restrictions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message