Return-Path: X-Original-To: apmail-activemq-issues-archive@minotaur.apache.org Delivered-To: apmail-activemq-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D06FB188F1 for ; Thu, 16 Jul 2015 11:37:04 +0000 (UTC) Received: (qmail 20182 invoked by uid 500); 16 Jul 2015 11:37:04 -0000 Delivered-To: apmail-activemq-issues-archive@activemq.apache.org Received: (qmail 20146 invoked by uid 500); 16 Jul 2015 11:37:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 20136 invoked by uid 99); 16 Jul 2015 11:37:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 11:37:04 +0000 Date: Thu, 16 Jul 2015 11:37:04 +0000 (UTC) From: "Robbie Gemmell (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (AMQ-5890) AMQP: possible NPE when handling disposition with Modified state MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Robbie Gemmell created AMQ-5890: ----------------------------------- Summary: AMQP: possible NPE when handling disposition with Modified state Key: AMQ-5890 URL: https://issues.apache.org/jira/browse/AMQ-5890 Project: ActiveMQ Issue Type: Bug Components: AMQP Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Minor Fix For: 5.12.0 If a consumer sends a disposition with Modified state in which the 'deliveryFailed' field is not populated, the broker will NPE. This is because the relevant value is a Boolean object rather than boolean primitive. That appears to be because there is actually no default value specified for the field in the specification, and it is defined only to be set when delivery actually failed (values that are not set are encoded nulls in the AMQP frame). The implementation needs updated to handle this value being null, but will be left permissive of it being set false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)