Return-Path: X-Original-To: apmail-activemq-issues-archive@minotaur.apache.org Delivered-To: apmail-activemq-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37A5C18789 for ; Thu, 11 Jun 2015 17:56:01 +0000 (UTC) Received: (qmail 91854 invoked by uid 500); 11 Jun 2015 17:56:01 -0000 Delivered-To: apmail-activemq-issues-archive@activemq.apache.org Received: (qmail 91737 invoked by uid 500); 11 Jun 2015 17:56:01 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 91528 invoked by uid 99); 11 Jun 2015 17:56:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2015 17:56:01 +0000 Date: Thu, 11 Jun 2015 17:56:00 +0000 (UTC) From: "clebert suconic (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ARTEMIS-87) Strip @author tags from Java source MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic updated ARTEMIS-87: ----------------------------------- Fix Version/s: (was: 1.1.0) 1.0.0 > Strip @author tags from Java source > ----------------------------------- > > Key: ARTEMIS-87 > URL: https://issues.apache.org/jira/browse/ARTEMIS-87 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 1.0.0 > Reporter: Justin Bertram > Assignee: Justin Bertram > Fix For: 1.0.0 > > > Way back in 2004 [the Apache Board officially discouraged the use of 'author' tags|http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt] in source code. They are not _banned_, but merely discouraged. However, I think it's probably a good idea to strip them from our source all the same. Other projects (e.g. [Camel|https://issues.apache.org/jira/browse/CAMEL-1812]) have done the same. > Here are a few other reasons to remove them (taken from [here|https://issues.jboss.org/browse/JBRULES-2895]): > The author tags in the java files are a maintenance nightmare: > - A large percentage is wrong, incomplete or inaccurate. > - Most of the time, it only contains the original author. Many files are completely refactored/expanded by other authors. > - Git is accurate, that is the canonical source to find the correct author. > To find the correct author of a piece of code, you always have to double check with git, you cannot suppose the author on the author tag alone. > - Author tags promote "code ownership", which is bad in the long run. > - If people work on a piece they perceive as being owned by someone else, they tend to: > -- only fix what they are assigned to fix, not everything that's broken. > -- discard responsibility if that code doesn't work properly. > -- be scared of stepping of the feet of the owner > - Instead of "code ownership", we need "module leadership" and "peer reviews". -- This message was sent by Atlassian JIRA (v6.3.4#6332)