activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5798) Invalid ActiveMQ connector options should be reported by throwing an error or warning
Date Wed, 27 May 2015 19:35:17 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561570#comment-14561570
] 

Timothy Bish commented on AMQ-5798:
-----------------------------------

Because the transport options are only lazily applied on an actual connect attempt by a client,
there is no Transport instance prior to that to test them on as they are applied via reflection.
 

> Invalid ActiveMQ connector options should be reported by throwing an error or warning
> -------------------------------------------------------------------------------------
>
>                 Key: AMQ-5798
>                 URL: https://issues.apache.org/jira/browse/AMQ-5798
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.11.0, 5.11.1
>         Environment: All
>            Reporter: JaySenSharma
>
> - Even if an incorrect (non existing) transport option is used in the "transportConnector"
URL still Broker does not complain anything about it.  Ideally it should throw an Error or
atleast show some WARNING messages.
> {code}
>         <transportConnectors>
>             <!-- DOS protection, limit concurrent connections to 1000 and frame size
to 100MB -->
>             <transportConnector name="openwire" uri="tcp://0.0.0.0:61616?maximumConnections=1000&amp;wireFormat.maxFrameSize=104857600&amp;transport.AAA=3600000"/>
>             <transportConnector name="amqp" uri="amqp://0.0.0.0:5672?maximumConnections=1000&amp;wireFormat.maxFrameSize=104857600&amp;transport.AAA=3600000"/>
>             <transportConnector name="stomp" uri="stomp://0.0.0.0:61613?maximumConnections=1000&amp;wireFormat.maxFrameSize=104857600&amp;transport.AAA=3600000"/>
>             <transportConnector name="mqtt" uri="mqtt://0.0.0.0:1883?maximumConnections=1000&amp;wireFormat.maxFrameSize=104857600&amp;transport.AAA=3600000"/>
>             <transportConnector name="ws" uri="ws://0.0.0.0:61614?maximumConnections=1000&amp;wireFormat.maxFrameSize=104857600&amp;transport.AAA=3600000"/>
>         </transportConnectors>
> {code}
> - *Notice* even if a non existing option is used *[transport.AAA=3600000]* above still
the broker starts fine without reporting any WARN/ERROR. Following entries can be seen in
the logs.
> {code}
> 2015-05-26 14:41:23,429 | INFO  | Using Persistence Adapter: KahaDBPersistenceAdapter[/home/jsensharma/NotBackedUp/DELETE/A/apache-activemq-5.11.1/data/kahadb]
| org.apache.activemq.broker.BrokerService | main
> 2015-05-26 14:41:23,668 | INFO  | Apache ActiveMQ 5.11.1 (localhost, ID:localhost-60479-1432631483544-0:1)
is starting | org.apache.activemq.broker.BrokerService | main
> 2015-05-26 14:41:23,684 | INFO  | Listening for connections at: tcp://localhost:61616?maximumConnections=1000&wireFormat.maxFrameSize=104857600&transport.AAA=3600000
| org.apache.activemq.transport.TransportServerThreadSupport | main
> 2015-05-26 14:41:23,688 | INFO  | Connector openwire started | org.apache.activemq.broker.TransportConnector
| main
> 2015-05-26 14:41:23,693 | INFO  | Listening for connections at: amqp://localhost:5672?maximumConnections=1000&wireFormat.maxFrameSize=104857600&transport.AAA=3600000
| org.apache.activemq.transport.TransportServerThreadSupport | main
> 2015-05-26 14:41:23,695 | INFO  | Connector amqp started | org.apache.activemq.broker.TransportConnector
| main
> 2015-05-26 14:41:23,700 | INFO  | Listening for connections at: stomp://localhost:61613?maximumConnections=1000&wireFormat.maxFrameSize=104857600&transport.AAA=3600000
| org.apache.activemq.transport.TransportServerThreadSupport | main
> 2015-05-26 14:41:23,703 | INFO  | Connector stomp started | org.apache.activemq.broker.TransportConnector
| main
> 2015-05-26 14:41:23,708 | INFO  | Listening for connections at: mqtt://localhost:1883?maximumConnections=1000&wireFormat.maxFrameSize=104857600&transport.AAA=3600000
| org.apache.activemq.transport.TransportServerThreadSupport | main
> 2015-05-26 14:41:23,711 | INFO  | Connector mqtt started | org.apache.activemq.broker.TransportConnector
| main
> 2015-05-26 14:41:24,116 | INFO  | Listening for connections at ws://localhost:61614?maximumConnections=1000&wireFormat.maxFrameSize=104857600&transport.AAA=3600000
| org.apache.activemq.transport.ws.WSTransportServer | main
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message