activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5792) Add a SubscriptionStatistics implementation to Subscriptions
Date Thu, 21 May 2015 19:56:18 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554953#comment-14554953
] 

ASF GitHub Bot commented on AMQ-5792:
-------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq/pull/102

    https://issues.apache.org/jira/browse/AMQ-5792 - Adding SubscriptionStatistics

    Adding SubscriptionStatistics to group together all metrics in a bean
    for a subscription.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq AMQ-5792

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #102
    
----
commit 134ae96ff4553221120f3ba7c3261b28716be3b7
Author: Christopher L. Shannon (cshannon) <christopher.l.shannon@gmail.com>
Date:   2015-05-21T19:47:22Z

    https://issues.apache.org/jira/browse/AMQ-5792
    
    Adding SubscriptionStatistics to group together all metrics in a bean
    for a subscription.

----


> Add a SubscriptionStatistics implementation to Subscriptions
> ------------------------------------------------------------
>
>                 Key: AMQ-5792
>                 URL: https://issues.apache.org/jira/browse/AMQ-5792
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.11.1
>            Reporter: Christopher L. Shannon
>
> I think it would be a good idea to create a {{SubscriptionStatistics}} class following
the same model as {{DestinationStatistics}}.  There are already several counters/metrics tracked
per subscription that could be moved into this new metrics class.  Accessing the values programmatically
would benefit because it would it is easier to just call a single gettter and receive a {{SubscriptionStatistics}}
object versus having to call several getters to get individual values.
> A future enhancement after this issue is complete is to expand the metrics and add new
ones.  For example, an inflight count is kept but it would also be nice to keep track of the
total byte size of the inflight messages as well.  
> I will be working on a pull request for this over the next couple of days and I will
push it up when it is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message