activemq-gitbox mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3594: ARTEMIS-3315 Fix JSON serialization of AMQP messages
Date Thu, 27 May 2021 02:00:03 GMT

clebertsuconic commented on a change in pull request #3594:
URL: https://github.com/apache/activemq-artemis/pull/3594#discussion_r640235803



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java
##########
@@ -173,7 +172,7 @@ public static void addToObject(final String key, final Object param, final
JsonO
          }
          jsonObjectBuilder.add(key, objectArrayBuilder);
       } else {
-         throw ActiveMQClientMessageBundle.BUNDLE.invalidManagementParam(param.getClass().getName());

Review comment:
       don't necessarily copy my version though. what I meant was the param instanceof Number..
   
   you probably should do the same for the Object[] ? just a suggestion though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message