From dev-return-70633-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu May 30 04:50:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4672C18064C for ; Thu, 30 May 2019 06:50:04 +0200 (CEST) Received: (qmail 20435 invoked by uid 500); 30 May 2019 04:50:03 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 20341 invoked by uid 99); 30 May 2019 04:49:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 May 2019 04:49:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CF377C2AF0 for ; Thu, 30 May 2019 04:49:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.498 X-Spam-Level: X-Spam-Status: No, score=-0.498 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_SHORT=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=me.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ShCYwYjP7zZE for ; Thu, 30 May 2019 04:49:56 +0000 (UTC) Received: from mr85p00im-hyfv06011401.me.com (mr85p00im-hyfv06011401.me.com [17.58.23.191]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E65B45F169 for ; Thu, 30 May 2019 04:49:55 +0000 (UTC) Received: from mail.outlook.com (unknown [52.125.140.63]) by mr85p00im-hyfv06011401.me.com (Postfix) with ESMTPSA id 23A9FD20CF1 for ; Thu, 30 May 2019 04:49:47 +0000 (UTC) Date: Thu, 30 May 2019 04:49:45 +0000 (UTC) From: michael.andre.pearce@me.com.INVALID To: dev@activemq.apache.org Message-ID: <23C8A0768C50A6D9.d766199e-3889-4267-8afa-4b7b412356f7@mail.outlook.com> In-Reply-To: References: Subject: Re: [DISCUSS] Component/Plugin repository MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_502_603084719.1559191785553" X-Mailer: Outlook for iOS and Android X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-30_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1905300036 ------=_Part_502_603084719.1559191785553 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit What ever the agreed place is i would want to see the same rules being applied across the board as noted this isnt the first time this has cropped up. That said. If we go seperate repo route. We could move other bits like docker and operator sub modules to sub repos there so they can have possibly a different lifecycle. In particular comment to Prometheus plugin. Would it be worth while also providing some base grafana dashboard people can just import to complement the metrics so end users have an even quicker onboarding journey. Get Outlook for Android On Wed, May 29, 2019 at 2:09 PM +0100, "Clebert Suconic" wrote: We could have a separate repository for these plugins... They could be part of our binary distribution (as being consumed), and we could have special CLI options to activate them. e.g.: ./artemis create /folder --plugin prometheus The prometheus plugin would be only applied if such option was applied. On Wed, May 29, 2019 at 6:54 AM Christopher Shannon wrote: > > This sounds good to me, I think it would be good to have some way to keep a > collection of plugins that is easy for people to find. I guess they could > either go into a new directory under the current Artemis build and each > have their own sub module/ jar or they could live by themselves in a new > sub project. > > I'm not really sure which approach would be best. Having new sub modules > makes it easy to keep the plugins in sync with the broker but can bloat the > release with things that may not belong in the main release (which is why > we didn't want the Kafka Bridge to be included as part of the main release) > > Having a new sub project could be nice so people can optionally grab > plugins only if they want them and this would allow the plugins could be > updated and released on their own schedule. The main downside I see with > the sub project approach is trying to keep plugins in sync with the broker > version. If we don't end up bundling the plugins with the broker itself > then we need to figure out how to handle compatibility across releases. > > On Tue, May 28, 2019 at 10:50 PM Justin Bertram wrote: > > > With the impending support for metrics plugins [1] as well as other > > pluggable components which have been discussed in the past (e.g. Kafka > > bridge [2] proposed by Mike Pearce) I think it would great to have an > > official place where these things could be hosted and potentially included > > as part of a broker release. Does anybody have any opinion on this? > > > > > > Justin > > > > [1] https://github.com/apache/activemq-artemis/pull/2681 > > [2] https://issues.apache.org/jira/browse/ARTEMIS-1478 > > -- Clebert Suconic ------=_Part_502_603084719.1559191785553--