activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with the request
Date Fri, 01 Mar 2019 10:33:36 GMT
k-wall commented on issue #2568: ARTEMIS-2262: Correlate management response messages with
the request
URL: https://github.com/apache/activemq-artemis/pull/2568#issuecomment-468620562
 
 
   @clebertsuconic @michaelandrepearce I'm struggling to find the right way to refactor by
moving responsibility for  `#setCorrelationID(Object)` and  `#getCorrelationID()` to Message.
 The difficulties I'm having come from the refactoring of `CoreAmqpConverter` and `AmpqCoreConverter`
and their interactions with `ServerJMSMessage`.  The fact that the conversion goes through
JMS model (Message#JMSCorrelationID() and Message#JMSCorrelationIDAsBytes is making things
awkward.  Indeed, I see a couple of places where the conversion side steps the ServerJMSMessage
completely.  I don't currently see the right way to proceed.
   
   Could you elaborate a bit more on how you'd approach this change in those areas?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message