From dev-return-70115-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Fri Feb 22 14:42:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A67C318077A for ; Fri, 22 Feb 2019 15:42:20 +0100 (CET) Received: (qmail 65113 invoked by uid 500); 22 Feb 2019 14:42:19 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 65091 invoked by uid 99); 22 Feb 2019 14:42:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Feb 2019 14:42:19 +0000 From: GitBox To: dev@activemq.apache.org Subject: [GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout Message-ID: <155084653900.32387.2839748678581007424.gitbox@gitbox.apache.org> Date: Fri, 22 Feb 2019 14:42:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368542 ########## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java ########## @@ -1350,10 +1350,12 @@ public void preHandleFailover(RemotingConnection connection) { // Needs to be synchronized to prevent issues with occurring concurrently with close() @Override - public void handleFailover(final RemotingConnection backupConnection, ActiveMQException cause) { + public boolean handleFailover(final RemotingConnection backupConnection, ActiveMQException cause) { Review comment: true usually means success. this is a bit confusing. Can you make it opposite. meaning handleFailover would return true if succeeded. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services