From dev-return-69765-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Mon Feb 4 19:03:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 04D02180679 for ; Mon, 4 Feb 2019 20:03:56 +0100 (CET) Received: (qmail 76651 invoked by uid 500); 4 Feb 2019 19:03:56 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 76640 invoked by uid 99); 4 Feb 2019 19:03:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2019 19:03:55 +0000 From: GitBox To: dev@activemq.apache.org Subject: [GitHub] orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images Message-ID: <154930703540.20179.3521575098080875617.gitbox@gitbox.apache.org> Date: Mon, 04 Feb 2019 19:03:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460370503 This looks very cool @franz1981! A few suggestions: 1. I'd probably arrange the ARTEMIS_VERSION so that it can be both a variable and an argument to the dockerfile. That way, you are not forced to change the Dockerfile for every release. ``` ARG ARTEMIS_VERSION ENV ARTEMIS_VERSION ${ARTEMIS_VERSION:-2.7.0-SNAPSHOT} LABEL ARTEMIS_VERSION=${ARTEMIS_VERSION} ``` 2. I think it would be good to label the Centos and Ubuntu images accordingly. ```LABEL ARTEMIS_BASE_SYSTEM=ubuntu``` Another thing you could do is consolidate the 2 files in one, so you could possibly reuse the container build code post the part that you setup the initial system. But I consider that a matter of personal taste and nothing that could give immediate gains to the image IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services