From dev-return-69700-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Fri Feb 1 02:35:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E6B6B18076D for ; Fri, 1 Feb 2019 03:35:34 +0100 (CET) Received: (qmail 13508 invoked by uid 500); 1 Feb 2019 02:35:33 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 13497 invoked by uid 99); 1 Feb 2019 02:35:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 02:35:33 +0000 From: GitBox To: dev@activemq.apache.org Subject: =?utf-8?q?=5BGitHub=5D_michaelandrepearce_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=232528=3A_ARTEMIS-2226_last_consumer_connection_should_?= =?utf-8?q?close_the_previous_consu=E2=80=A6?= Message-ID: <154898853306.7676.7978652398057430374.gitbox@gitbox.apache.org> Date: Fri, 01 Feb 2019 02:35:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252916780 ########## File path: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java ########## @@ -30,10 +30,12 @@ public class MQTTSession { - static Map SESSIONS = new ConcurrentHashMap<>(); + private static Map SESSIONS = new ConcurrentHashMap<>(); Review comment: i sent a possible solution to address this, in a pr to your branch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services