activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to the documentation
Date Thu, 28 Feb 2019 23:31:31 GMT
michaelandrepearce commented on a change in pull request #2571: Added Javadoc reference to
the documentation
URL: https://github.com/apache/activemq-artemis/pull/2571#discussion_r261428128
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
 ##########
 @@ -357,6 +357,7 @@
     * @param uri  the URI of the acceptor
     * @return this
     * @throws Exception in case of Parsing errors on the URI
+    * @see <a href="https://activemq.apache.org/artemis/docs/latest/configuring-transports.html">Configuring
the Transport</a>
 
 Review comment:
   IMO This isnt a good idea, as location of docs url can change in time as we release new
version, and once code is tagged and release we cannot go back and change the links in previously
released code. If needed the java doc itself could be enriched.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message