activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List
Date Mon, 25 Feb 2019 17:42:29 GMT
michaelandrepearce commented on a change in pull request #2564: ARTEMIS-2183 Useless statement
in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259939801
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
 ##########
 @@ -190,9 +190,7 @@ private void decrementRefCount(MessageReference refmsg) {
 
    @Override
    public synchronized List<MessageReference> getRelatedMessageReferences() {
-      List<MessageReference> listRet = new LinkedList<>();
 
 Review comment:
   I think the point here is the code is addall of the list it just created. This seems very
odd. 
   
   Id agree an internal list should just be exposed. But the current logic just looks crazy
wrong. Youd be better to return Collections.emptylist!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message