activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable
Date Fri, 22 Feb 2019 10:31:35 GMT
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager
directory should be configurable
URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259288569
 
 

 ##########
 File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
 ##########
 @@ -608,6 +608,14 @@
             </xsd:annotation>
          </xsd:element>
 
+         <xsd:element name="node-manager-lock-directory" type="xsd:string" maxOccurs="1"
minOccurs="0">
 
 Review comment:
   > Do we need separate entries for lock and node manager lock ?
   
   I suppose yes, because are used for different purposes:
   
   - cli lock is used by cli commands to avoid executing in parallel with a specific broker
instance
   - node manager lock is used to coordinate different broker instances
   
   I don't think is a good idea to mix their configurations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message