activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed
Date Wed, 20 Feb 2019 02:24:50 GMT
michaelandrepearce commented on a change in pull request #2549: ARTEMIS-2251 Large messages
might not be deleted when server crashed
URL: https://github.com/apache/activemq-artemis/pull/2549#discussion_r258310314
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ##########
 @@ -432,7 +432,7 @@ public void freeDirectBuffer(ByteBuffer buffer) {
       journalFF.releaseBuffer(buffer);
    }
 
-   public long storePendingLargeMessage(final long messageID, long recordID) throws Exception
{
 
 Review comment:
   There is diff between a memory block and an waiting on disk io.
   
   Can this not be async in a different thread with a callback with a response later? 
   
   How are normal messages deleted? So these are not disk io blocking 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message