activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images
Date Mon, 04 Feb 2019 19:03:55 GMT
orpiske commented on issue #2536: ARTEMIS-2245 Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460370503
 
 
   This looks very cool @franz1981! 
   
   A few suggestions:
   1. I'd probably arrange the ARTEMIS_VERSION so that it can be both a variable and an argument
to the dockerfile. That way, you are not forced to change the Dockerfile for every release.

   
   ```
   ARG ARTEMIS_VERSION
   ENV ARTEMIS_VERSION ${ARTEMIS_VERSION:-2.7.0-SNAPSHOT}
   LABEL ARTEMIS_VERSION=${ARTEMIS_VERSION}
   ```
   
   2. I think it would be good to label the Centos and Ubuntu images accordingly. 
   ```LABEL ARTEMIS_BASE_SYSTEM=ubuntu```
   
   Another thing you could do is consolidate the 2 files in one, so you could possibly reuse
the container build code post the part that you setup the initial system. But I consider that
a matter of personal taste and nothing that could give immediate gains to the image IMHO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message