From dev-return-68652-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Thu Jan  3 19:48:25 2019
Return-Path: <dev-return-68652-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B390E180608
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Jan 2019 19:48:24 +0100 (CET)
Received: (qmail 49840 invoked by uid 500); 3 Jan 2019 18:48:23 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 49829 invoked by uid 99); 3 Jan 2019 18:48:23 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2019 18:48:23 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 051ABE0968; Thu,  3 Jan 2019 18:48:23 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2484-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2484-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2484: ARTEMIS-2216 Use a specific executor fo...
Content-Type: text/plain
Message-Id: <20190103184823.051ABE0968@git1-us-west.apache.org>
Date: Thu,  3 Jan 2019 18:48:23 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2484#discussion_r245095523
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java ---
    @@ -1350,7 +1350,7 @@ public synchronized boolean hasNext() {
                 return true;
              }
     
    -         if (!pageStore.isPaging()) {
    +         if (!pageStore.isPagingDirtyRead()) {
    --- End diff --
    
    Concern here is this ins't an async case.
    
    Btw i cannot see the change in QueueImpl to use the new paging dirty read.


---