From dev-return-69602-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Jan 30 09:22:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1DBE3180677 for ; Wed, 30 Jan 2019 10:22:09 +0100 (CET) Received: (qmail 34223 invoked by uid 500); 30 Jan 2019 09:22:08 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 34199 invoked by uid 99); 30 Jan 2019 09:22:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 09:22:08 +0000 From: GitBox To: dev@activemq.apache.org Subject: =?utf-8?q?=5BGitHub=5D_onlyMIT_commented_on_a_change_in_pull_request_=232?= =?utf-8?q?528=3A_ARTEMIS-2226_last_consumer_connection_should_close_the_p?= =?utf-8?q?revious_consu=E2=80=A6?= Message-ID: <154884012806.4078.14394219101838344446.gitbox@gitbox.apache.org> Date: Wed, 30 Jan 2019 09:22:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252172517 ########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ########## @@ -343,6 +347,18 @@ public void onNotification(final Notification notification) { if (binding != null) { // We have a local queue Queue queue = (Queue) binding.getBindable(); + //If the client ID represents a client already connected to the server then the server MUST disconnect the existing client. + //Avoid consumers with the same client ID in the cluster appearing at different nodes at the same time + SimpleString protocolName = props.getSimpleStringProperty(ManagementHelper.HDR_PROTOCOL_Name); Review comment: Thanks, very nice advice. i will done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services