From dev-return-69343-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Jan 24 19:48:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05670180771 for ; Thu, 24 Jan 2019 19:48:09 +0100 (CET) Received: (qmail 58281 invoked by uid 500); 24 Jan 2019 18:48:09 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 58260 invoked by uid 99); 24 Jan 2019 18:48:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2019 18:48:08 +0000 From: GitBox To: dev@activemq.apache.org Subject: [GitHub] clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. Message-ID: <154835568828.1125.1201678673073559264.gitbox@gitbox.apache.org> Date: Thu, 24 Jan 2019 18:48:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250732153 ########## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java ########## @@ -157,7 +157,12 @@ public NetworkHealthCheck parseURIList(String addressList) { @Override protected ActiveMQThreadFactory getThreadFactory() { - return new ActiveMQThreadFactory("NetworkChecker", "Network-Checker-", false, getThisClassLoader()); Review comment: This is just creating a ThreadFactory.. is it really needed? I would expect a security check around new Threads, but against a new ActiveMQThreadFactory? are you sure about it? just checking it's not a typo? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services