From dev-return-69184-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Tue Jan 22 08:02:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5222C180771 for ; Tue, 22 Jan 2019 08:02:40 +0100 (CET) Received: (qmail 17462 invoked by uid 500); 22 Jan 2019 07:02:39 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 17451 invoked by uid 99); 22 Jan 2019 07:02:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jan 2019 07:02:39 +0000 From: GitBox To: dev@activemq.apache.org Subject: [GitHub] michaelandrepearce commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering Message-ID: <154814055851.6777.584906231456176102.gitbox@gitbox.apache.org> Date: Tue, 22 Jan 2019 07:02:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit michaelandrepearce commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249659861 ########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java ########## @@ -117,7 +117,9 @@ public void addBinding(final Binding binding) { logger.trace("addBinding(" + binding + ") being called"); } if (binding.isExclusive()) { - exclusiveBindings.add(binding); + if (!exclusiveBindings.contains(binding)) { Review comment: Just change commit comment slighty and force push ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services