activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2494: ARTEMIS-2224 Reduce contention on LiveP...
Date Wed, 09 Jan 2019 22:05:27 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2494#discussion_r246563763
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
    @@ -28,15 +28,49 @@
     /**
      * This is the same as PageCache, however this is for the page that's being currently
written.
      */
    --- End diff --
    
    @franz1981 Id agree with @clebertsuconic here, a bit like what ive done with priority
consumers, i ended up splitting out the collections logic, which has ended up making it cleaner,
and easier to reason with. (and as youve marked out on its pr, more testable ;) )


---

Mime
View raw message