activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2492: ARTEMIS-2222 why the position remains u...
Date Wed, 09 Jan 2019 20:51:03 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2492#discussion_r246538095
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
    @@ -1315,9 +1315,7 @@ private PagedReference moveNext() {
                       }
                    }
     
    -               if (!ignored) {
    -                  position = message.getPosition();
    -               }
    +               position = message.getPosition();
    --- End diff --
    
    I think this made sense at some point, but after a few fixes later it's harmless.
    
    I don't think this needs a JIRA as there's no issue I think.
    
    I will merge and keep the JIRA, but I will rename the commit from being a question into
something more affirmative.


---

Mime
View raw message