activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2490: V2 196
Date Wed, 09 Jan 2019 15:13:36 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2490#discussion_r246398611
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
    @@ -104,6 +119,11 @@ public void decodeRest(final ActiveMQBuffer buffer) {
           filterString = buffer.readNullableSimpleString();
           browseOnly = buffer.readBoolean();
           requiresResponse = buffer.readBoolean();
    +      if (buffer.readableBytes() > 0) {
    --- End diff --
    
    Does this comment cover to the bit around the safety of always sending the new additional
data even to old servers? I can't tell if its covered.
    
    I think it should at the very least be commented what/when the encoding+decoding handling
behaviour changed so folks can understand the implications later without heading to find past
commits.


---

Mime
View raw message