activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2490: V2 196
Date Wed, 09 Jan 2019 13:22:28 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2490#discussion_r246377289
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
    @@ -2409,14 +2410,10 @@ private void deliver() {
           // Either the iterator is empty or the consumer is busy
           int noDelivery = 0;
     
    -      int size = 0;
    -
    -      int endPos = -1;
    -
           int handled = 0;
     
           long timeout = System.currentTimeMillis() + DELIVERY_TIMEOUT;
    -
    +      consumers.reset();
    --- End diff --
    
    if any exception would be thrown before it is ok that `reset` won't be called? 
    If not, better to wrap the whole logic with ├Čtry..finally` and `reset` 


---

Mime
View raw message